Address code review suggestions

stolostron · Jun 10, 2024 · f0b4815 · f0b4815
1 parent a2a30df
commit f0b4815
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -139,7 +139,7 @@ Currently the addon supports configuration to send logs either to:
 - CloudWatch: requires the auth configmap to be specified
 - Loki: requires the auth configmap, the url configmap and optionally the inject ca configmap
 
-### Traces Collection & Instrumentation 
+### Traces Collection
 
 Currently MCOA supports deploying a single instance of `OpenTelemetryCollector`
 templated with the stanza created in the hub cluster. The instance deployed in

diff --git a/internal/addon/helm/values.go b/internal/addon/helm/values.go
@@ -51,7 +51,7 @@ func GetValuesFunc(ctx context.Context, k8s client.Client) addonfactory.GetValue
 		}
 
 		if opts.Platform.Logs.CollectionEnabled || opts.UserWorkloads.Logs.CollectionEnabled {
-			loggingOpts, err := lhandlers.BuildOptions(ctx, k8s, mcAddon, opts.Platform.Logs, opts.Platform.Logs)
+			loggingOpts, err := lhandlers.BuildOptions(ctx, k8s, mcAddon, opts.Platform.Logs, opts.UserWorkloads.Logs)
 			if err != nil {
 				return nil, err
 			}