Use console quick start drawer #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawagner
reviewed
Aug 16, 2023
| @@ -38,7 +38,6 @@ import { getResourceVendor } from '../../utils/clusterTemplateDataUtils'; | |||
| import useClusterTemplateActions from '../../hooks/useClusterTemplateActions'; | |||
| import useClusterTemplateDeserializer from '../../hooks/useClusterTemplateDeserializer'; | |||
| import Alerts from '../../alerts/Alerts'; | |||
| import WithClusterTemplateQuickStarts from '../ClusterTemplatesGettingStarted/WithClusterTemplateQuickStarts'; | |||
There was a problem hiding this comment.
WithClusterTemplateQuickStarts can be removed completely, right ?
rawagner
approved these changes
Aug 16, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: batzionb, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make quick starts open in the console drawer instead of the one embedded in the cluster templates page, this way they stay open also when navigating to other pages.
The fix is done by not wrapping the components with a QuickStart context, this way the console one is used
before
after