add OPTIONAL_PARAMS for ROSA

[hchenxa]

Signed-off-by: hchenxa [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hchenxa
To complete the pull request process, please assign schmidtd after the PR has been reviewed.
You can assign the PR to them by writing /assign @schmidtd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hchenxa]

/assign @schmidtd

[schmidtd]

Rather than combining generic OPTIONAL_PARAMS with options specific to --multi-az, I'd suggest name-scoping a new optional parameter like MULTI-AZ-PARAMS and using that in the --multi-az line.

[hchenxa]

how about add the OPTIONAL_PARAMS at the end of command like below:

${ROSA} create cluster \
    --cluster-name=${RESOURCE_NAME} \
    --region=${AWS_REGION} \
    --version=${OCP_VERSION} \
    --compute-machine-type=${AWS_WORKER_TYPE} \
    --compute-nodes=${AWS_WORKER_COUNT} \
    --channel-group=${CHANNEL_GROUP} \
    --multi-az \
    --watch \
    --yes ${OPTIONAL_PARAMS}

since the parameter was not for mult-az, so I think it may make confused if we use the name-scoping parameters.

[schmidtd]

It would be nice if it could be on its own line to make it clear that it doesn't belong with any of the current parameters (the reason I mistook it for belonging to multi-az), but I can see how that might cause different problems if it were blank vs. non-blank. Adding it to the end is at least better than having it up a few lines the way it is currently.