Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automatic mode open a temporary container only if I'm in default container #98

Closed
spastorino opened this issue Mar 18, 2018 · 14 comments

Comments

@spastorino
Copy link

If I go an open a permanent container where I use a specific gmail account I don't want automatic mode to interfere with it.

@stoically
Copy link
Owner

stoically commented Mar 18, 2018

Automatic Mode doesn't interfere with regular loading of websites in permanent containers. Though, I just realized that if you try to load a website in a permanent container that is assigned to "Always open in" in another permanent container with Multi-Account Containers, then you only get to choose between a temporary container and the assigned permanent container - not the permanent container you originally wanted to load the site in. That should not be the case, but it should indeed let you choose the original container you wanted to load the website in. If that's not your use-case, then please let me know what exactly you experience, how to reproduce it and if you maybe have other preferences configured.

Another solution would be if it'd be possible to assign multiple containers, and with that also be able to choose from multiple containers (including a temporary one): mozilla/multi-account-containers#849

@spastorino
Copy link
Author

spastorino commented Mar 19, 2018

That's exactly what's happening to me and this mozilla/multi-account-containers#849 if implemented is great.

Not sure if you need more info, let me know if you do :).

@stoically
Copy link
Owner

Just published version 0.77 with the enhancement. Let me know if something isn't working as expected.

@spastorino
Copy link
Author

@stoically solution is perfect meanwhile mozilla/multi-account-containers#849 is implemented.

@spastorino
Copy link
Author

@stoically there's still an issue that's happening in one gmail account that's not the one used by default which uses two factor authentication. After the first question being correct and letting me open the right container, I get redirected see ...

screenshot from 2018-03-21 21-59-23

And I'm back in the same issue.

@spastorino
Copy link
Author

BTW, I think it's not related with two factor auth. When I said it worked was because I was already logged in in the corresponding container but if you're not you get a redirect and suggest Tmpxxx container instead of the right one

@stoically
Copy link
Owner

@spastorino Could you maybe provide some steps on how to reproduce (maybe even including a debug log)? I'm unfortunately not able to reproduce it myself.

@stoically stoically reopened this Mar 22, 2018
@spastorino
Copy link
Author

Ok, sorry for not being clear and thanks for your help and work :).

Let me try to explain better ...
I have a personal gmail account which I'm logged in, in a container called Gmail Personal. The url I visit is https://mail.google.com/mail/ and the option Always open in Gmail Personal is activated for this url. Then I have another work email under Gmail WyeWorks container using the same url.
What I want is to open Gmail WyeWorks container and use my work email.

To reproduce the issue ...

  1. Logout gmail on Gmail WyeWorks container
  2. Open a tab on Gmail WyeWorks container
  3. https://mail.google.com/mail/
  4. It ask to open in Gmail WyeWorks or Gmail Personal, choose Gmail WyeWorks
  5. Fill name and password and try to log in
  6. You will be redirected and in that part is where you will see ...
    screenshot from 2018-03-21 21-59-23
    And you will need to open in Gmail WyeWorks again instead of Gmail Personal or a tmp container.

I think the issue is more general, in a situation like the one described in this issue, when you're redirected the plugin is losing track of where the container was firstly opened. I guess you would like to respect in what container was firstly opened the tab for all the session I'd say. Otherwise, when there's a redirect to https://mail.google.com/mail/ with some params in the url you will hit again the same issue.

Hope what I wrote helps, otherwise I will try to clarify more. Do you need a debug log?. Where does the plugin store that?.

@stoically
Copy link
Owner

No problem and thanks for the additional informations. Unfortunately I'm still not able to reproduce the issue. If I select the not-assigned container on the confirm page I can login without further interruptions.

So in this case a debug log would be really helpful to track down the problem:

  • Open a new tab and navigate to "about:debugging"
  • Tick the "Enable debugging" checkbox (untick again when you're done posting the Issue)
  • Scroll down to Temporary Containers and click the "Debug" link
  • Confirm the dialog with OK, you now see "Developer Tools" with "Console" selected
  • Type into the console "log.DEBUG=true" (without the quotes), it should respond with "true" (type "log.DEBUG=false" into the console when you're done posting the Issue)
  • Now reproduce your issue
  • Switch back to the "Developer Tools", select everything in the console
  • Copy everything in the console, paste it into a .txt file, save the file, and attach it to the comment by drag&drop'ing it into the text-box

@spastorino
Copy link
Author

Ok, I know what the issue is about. I can send you the debug log if you're interested but anyway, the thing is ...

First, just in case I didn't mention, I've enabled Isolation -> Multi Account Containers
Then, in my case I'm being redirected to log in at some point to https://accounts.google.com and https://accounts.google.com.uy
In order to fix the issue I should put both on Always open in Gmail Personal, otherwise, due to Isolation -> Multi Account Containers they will both be opened in Tmp containers.
I've added https://accounts.google.com to Always open in Gmail Personal, the thing is https://accounts.google.com.uy only redirects to https://accounts.google.com and I can't using the UI add also that address so I keep hitting this issue. Was looking to do so using the config files, still looking ...

@stoically
Copy link
Owner

Glad you figured out the actual issue. A rather hacky way to get the .uy domain on the "Always open in" list is to temporarly set network.http.redirection-limit in about:config to 0

Possible actual solutions:

@spastorino
Copy link
Author

What I do is disable Temporary Containers to login and then enable it again. After I'm logged in I don't have any issues and I keep my gmail logged in so ... for now this trick works.

@stoically
Copy link
Owner

Ah, yeah, that's indeed the only solution in this case, since you probably don't want to assign the .uy domain to only the "WyeWorks" container. I'll look into implementing #104

@spastorino
Copy link
Author

Yep I also thought about something like #104, so would be great when that's available :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants