Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you accept requests for compatibilities with other containers extensions? #286

Closed
Fanolian opened this issue Jul 8, 2019 · 6 comments

Comments

@Fanolian
Copy link

Fanolian commented Jul 8, 2019

Reference: #125, #261

Thank you for supporting some other popular containers extensions. There are, however, still many similar extensions which contain other popular services and may conflict with TC. (I use Amazon Container which causes infinite loop of respawning containers like what TC did to facebook container.)

Do you accept requests for compatibilities with other containers extensions? I understand this will increase your workload and divert your time from improving the core features of TC. So I think I should ask before making a request.

Thank you for your extension.

@stoically
Copy link
Owner

stoically commented Jul 8, 2019

Sure, no problem, I can add compatibility with other Container Add-ons of that kind on demand. It's just copy&paste. (and a pitty that the original Facebook Container didn't open up the API to other extensions, that way all forks would provide their URLs, oh well)

@stoically
Copy link
Owner

Though, if you're asking for compatibility with Container Add-ons that aren't forks from Facebook Container (like #261) - that needs to be investigated on a case-by-case basis and almost certainly depends on whether the other Add-on has or is willing to provide an API.

@MikeRixWolfe
Copy link

Hello, I'm also running into the infinite loop of temp containers spawning too, when using it in combination with the Containerise extension. Though it's not a Facebook Container fork, it's more of a MAC alternative that allows defining containers explicitly and with wildcards, would it be something you could investigate adding compatibility for similarly?

Thanks for your work 😀

@MikeRixWolfe
Copy link

Let me know if you'd prefer I open a new issue for this

@crssi
Copy link

crssi commented Jul 9, 2019

Hello, I'm also running into the infinite loop of temp containers spawning too, when using it in combination with the Containerise extension. Though it's not a Facebook Container fork, it's more of a MAC alternative that allows defining containers explicitly and with wildcards, would it be something you could investigate adding compatibility for similarly?

Thanks for your work grinning

Quote from @dboy591

The breakage with TC seems to be due to the lack of a "No Container" in this latest version of Containerise. Manually reverting to the previous version for now.

kintesh/containerise#70 (comment)

@stoically
Copy link
Owner

Amazon Container compatibility added in v1.1. In general im open to add compatibility, as long as it's possible and not too hard. Please open a new issue per Add-on so I can decide on a case-by-case basis. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants