Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement suggestion for container name prefix #140

Closed
crssi opened this issue May 8, 2018 · 12 comments
Closed

Improvement suggestion for container name prefix #140

crssi opened this issue May 8, 2018 · 12 comments

Comments

@crssi
Copy link

crssi commented May 8, 2018

Is it possible to add option to container name prefix, to be prefixed by opening domain?

Thank you
cheers

@crssi crssi changed the title Improvement suggestion Improvement suggestion for container name prefix May 8, 2018
@stoically
Copy link
Owner

I guess I could add replacement variables like %domain% (host + public suffix) and %fulldomain% (fqdn) that could be entered in the Prefix field as advanced option.

@stoically
Copy link
Owner

Just realized that replacement variables wouldn't be so nice, since there are cases like the default ways of opening a new Temporary Container where there's no data available about domains. If you e.g. set the prefix just to %domain%, you would end up with just a number as container name. The other way might be a checkbox like "Use domain-name as prefix if available", but I personally feel like that's really confusing. Which way would you prefer and where do you see the benefit in the feature itself?

@crssi
Copy link
Author

crssi commented May 9, 2018

Just realized that replacement variables wouldn't be so nice, since there are cases like the default ways of opening a new Temporary Container where there's no data available about domains. If you e.g. set the prefix just to %domain%, you would end up with just a number as container name,

I really don't see any downsides to this.

Maybe it would also be nice to hard-prefix the number itself like #1. #2, #3.. etc.

Do not forget to trim() at the end of naming generation process.

Let's sleep over. 😄

@listalltabs
Copy link

listalltabs commented May 9, 2018

If the container name includes a domain, what would happen if there are two or more domains open in the same container? e.g.

  • open site A in tmp1234
  • open new tmp1234 tab
  • open site B in that new tab

What would the container name be if a domain name was incorporated into it? To ensure site B didn't open in the same container as site A, isolation would need to be taken a step further I'd guess! :)

EDIT: ah, I'd forgotten that we can isolate Per Domain, which would open site B above in a different container if set. Maybe full isolation, per domain, would be required to allow domains to be included as part of container names? Just thinking out loud; feel free to ignore! :)

@stoically
Copy link
Owner

stoically commented May 9, 2018

@crssi

I really don't see any downsides to this.

In this case - I've added it accordingly, will be available with the next release.

Maybe it would also be nice to hard-prefix the number itself like #1. #2, #3.. etc.

You can do that by just adding a # as last character in the prefix.

Do not forget to trim() at the end of naming generation process.

I don't want to limit people in being creative, even with whitespaces. :D

@listalltabs

The number is always present in the container name, so the change would only affect the prefix of the container name, nothing else.

@crssi
Copy link
Author

crssi commented May 15, 2018

On 0.90beta1 this now works perfectly.

Thank you

@stoically
Copy link
Owner

It's also published as version 0.90 now, good to know it works for you!

@hackel
Copy link

hackel commented Dec 4, 2018

I just enabled this feature, and the issue @stoically mentioned is a minor annoyance. In my case, I just went with "%domain% - tmp", so each time I open a new tab, it gets named e.g. " - tmp3" and that name doesn't change once I actually go to a domain, thereby defeating the whole point. This isn't an issue if I enable "Don't reopen New Tabs in Temporary Containers," though I find the privacy implications concerning.

@crssi
Copy link
Author

crssi commented Dec 5, 2018

@hackel
I am going only with "%domain% #". "tmp" is just unnecessary bloat.

I can write the way I am using TC, if you are interested?

@hackel
Copy link

hackel commented Dec 6, 2018

@crssi I see what you're saying, but how do you differentiate temporary containers from permanent containers? Just based on whether they have a number at the end? The default name when you convert a temporary container to permanent is the domain name, so it's hard to tell at a glance. And as you said, without a trim, the issue is still there, just less visible.

@crssi
Copy link
Author

crssi commented Dec 7, 2018

@hackel
I am also using DDG as search service, but I am using only over navigation bar.
I don't use permanent containers. I did those at the past, but I didn't like the idea and frankly I don't know why I would need a permanent containers.
I happens to me quite often that I want to open same web service but logged in as different account.

This is how I have configured TC: https://github.com/crssi/Firefox/blob/master/temporary_containers_preferences.json

As you see I also distinguish containers by color and not only a domain+number.

Additionally to TC, I am using Context Plus to switch between context (migrating tab into another container).

I did use M-AC and Containerise, but I had a problem with those, so I have ditched them.

I am using Firefox with user.js and profile described at https://github.com/crssi/Firefox/blob/master/user-overrides.js which is supplement to https://github.com/ghacksuserjs/ghacks-user.js.

I understand that everyone has its own modus operandy browsing and experience the web, I am just saying how I am doing it.

If you have any questions, let me know.

Cheers

@crssi
Copy link
Author

crssi commented Dec 7, 2018

Oh, forgot to explain some more...

LMC (left mouse click) should not open URL in a new container, otherwise we have breakages on login pages where login is redirected to login provider and then back to visiting page.
MMC (middle mouse click) forces to open URL in a new container if the domain is different.
When clicking on a DDG search results I am using MMC.
If for any reason I do a LMC then back action will force to open DDG in a new container to avoid container infection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants