-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement suggestion for container name prefix #140
Comments
I guess I could add replacement variables like |
Just realized that replacement variables wouldn't be so nice, since there are cases like the default ways of opening a new Temporary Container where there's no data available about domains. If you e.g. set the prefix just to |
I really don't see any downsides to this. Maybe it would also be nice to hard-prefix the number itself like Do not forget to trim() at the end of naming generation process. Let's sleep over. 😄 |
If the container name includes a domain, what would happen if there are two or more domains open in the same container? e.g.
What would the container name be if a domain name was incorporated into it? To ensure site B didn't open in the same container as site A, isolation would need to be taken a step further I'd guess! :) EDIT: ah, I'd forgotten that we can isolate Per Domain, which would open site B above in a different container if set. Maybe full isolation, per domain, would be required to allow domains to be included as part of container names? Just thinking out loud; feel free to ignore! :) |
In this case - I've added it accordingly, will be available with the next release.
You can do that by just adding a # as last character in the prefix.
I don't want to limit people in being creative, even with whitespaces. :D The number is always present in the container name, so the change would only affect the prefix of the container name, nothing else. |
On 0.90beta1 this now works perfectly. Thank you |
It's also published as version 0.90 now, good to know it works for you! |
I just enabled this feature, and the issue @stoically mentioned is a minor annoyance. In my case, I just went with "%domain% - tmp", so each time I open a new tab, it gets named e.g. " - tmp3" and that name doesn't change once I actually go to a domain, thereby defeating the whole point. This isn't an issue if I enable "Don't reopen New Tabs in Temporary Containers," though I find the privacy implications concerning. |
@hackel I can write the way I am using TC, if you are interested? |
@crssi I see what you're saying, but how do you differentiate temporary containers from permanent containers? Just based on whether they have a number at the end? The default name when you convert a temporary container to permanent is the domain name, so it's hard to tell at a glance. And as you said, without a trim, the issue is still there, just less visible. |
@hackel This is how I have configured TC: https://github.com/crssi/Firefox/blob/master/temporary_containers_preferences.json As you see I also distinguish containers by color and not only a domain+number. Additionally to TC, I am using Context Plus to switch between context (migrating tab into another container). I did use M-AC and Containerise, but I had a problem with those, so I have ditched them. I am using Firefox with user.js and profile described at I understand that everyone has its own modus operandy browsing and experience the web, I am just saying how I am doing it. If you have any questions, let me know. Cheers |
Oh, forgot to explain some more... LMC (left mouse click) should not open URL in a new container, otherwise we have breakages on login pages where login is redirected to login provider and then back to visiting page. |
Is it possible to add option to container name prefix, to be prefixed by opening domain?
Thank you
cheers
The text was updated successfully, but these errors were encountered: