Fix Deletes History Container not cleaning history with deactivated a…

…utomatic mode Part of #17
stoically · Feb 4, 2018 · 282e2ee · 282e2ee
1 parent 8cffec6
commit 282e2ee
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/src/background/request.js b/src/background/request.js
@@ -16,15 +16,6 @@ class Request {
       debug('[browser.webRequest.onBeforeRequest] onBeforeRequest request doesnt belong to a tab, why are you main_frame?', request);
       return;
     }
-    let alwaysOpenIn = false;
-    if (this.shouldAlwaysOpenInTemporaryContainer(request)) {
-      debug('[browser.webRequest.onBeforeRequest] always open in tmpcontainer request', request);
-      alwaysOpenIn = true;
-    } else if (!this.storage.local.preferences.automaticMode &&
-               !this.mouseclick.linksClicked[request.url]) {
-      debug('[browser.webRequest.onBeforeRequest] automatic mode disabled and no link clicked', request);
-      return;
-    }
 
     let tab;
     try {
@@ -52,6 +43,16 @@ class Request {
       await this.storage.persist();
     }
 
+    let alwaysOpenIn = false;
+    if (this.shouldAlwaysOpenInTemporaryContainer(request)) {
+      debug('[browser.webRequest.onBeforeRequest] always open in tmpcontainer request', request);
+      alwaysOpenIn = true;
+    } else if (!this.storage.local.preferences.automaticMode &&
+               !this.mouseclick.linksClicked[request.url]) {
+      debug('[browser.webRequest.onBeforeRequest] automatic mode disabled and no link clicked', request);
+      return;
+    }
+
     if (alwaysOpenIn && !this.mouseclick.linksClicked[request.url] && tab.openerTabId) {
       debug('[browser.webRequest.onBeforeRequest] always open in tmpcontainer request, simulating click', request);
       this.linkClicked(request.url, {