Lets not isolate blank tabs

Part of #56
stoically · Mar 6, 2018 · 060da14 · 060da14
1 parent 821499b
commit 060da14
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/background/request.js b/src/background/request.js
@@ -382,6 +382,11 @@ class Request {
       return true;
     }
 
+    if (tab.url === 'about:blank') {
+      debug('[shouldIsolate] not isolating because the tab url is blank');
+      return false;
+    }
+
     if (tab.url === 'about:blank' && this.requestsSeen[request.requestId]) {
       debug('[shouldIsolate] not isolating because the tab url is blank and we seen this request before, probably redirect');
       return false;

diff --git a/src/ui/options.html b/src/ui/options.html
@@ -144,7 +144,7 @@ <h4 data-tooltip="Website Rules overwrite Global Preferences">
             <div class="field">
               <select id="isolationDomainAction" class="ui fluid dropdown">
                 <option value="always">Always</option>
-                <option value="notsamedomainexact">Only if the navigation target doesn't exactly match the Tabs Website Domain</option>
+                <option value="notsamedomainexact" selected="selected">Only if the navigation target doesn't exactly match the Tabs Website Domain</option>
                 <option value="notsamedomain">Only if the navigation target doesn't match the Tabs Website Domain (includes Subdomains)</option>
                 <option value="never">Never</option>
               </select>