feat: hide container number (#281)

stoically · Nov 2, 2019 · 0142cb3 · 0142cb3
1 parent 728bdc9
commit 0142cb3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json
@@ -116,6 +116,9 @@
   "optionsGeneralContainerNumberReuseNumbers": {
     "message": "Reuse available numbers"
   },
+  "optionsGeneralContainerNumberHide": {
+    "message": "Hide number"
+  },
   "optionsGeneralContainerRemoval": {
     "message": "Delete no longer needed Temporary Containers"
   },

diff --git a/src/background/container.js b/src/background/container.js
@@ -204,7 +204,7 @@ class Container {
 
 
   getContainerNameIconColor(url) {
-    let tempContainerNumber;
+    let tempContainerNumber = '';
     if (this.pref.container.numberMode.startsWith('keep')) {
       this.storage.local.tempContainerCounter++;
       tempContainerNumber = this.storage.local.tempContainerCounter;
@@ -229,6 +229,9 @@ class Container {
         .replace('%domain%', '');
     }
     containerName = `${containerName}${tempContainerNumber}`;
+    if (!containerName) {
+      containerName = ' ';
+    }
 
     let containerColor = this.pref.container.color;
     if (this.pref.container.colorRandom) {

diff --git a/src/ui/components/general.vue b/src/ui/components/general.vue
@@ -312,6 +312,9 @@ export default {
           <option value="reuse">
             {{ t('optionsGeneralContainerNumberReuseNumbers') }}
           </option>
+          <option value="hide">
+            {{ t('optionsGeneralContainerNumberHide') }}
+          </option>
         </select>
       </div>
       <div class="field">