Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSLCert Upload to Supermicro UpdateService #378

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

lamaral
Copy link
Contributor

@lamaral lamaral commented Oct 21, 2024

What a coincidence, it just so happened that I worked on the UpdateService for Supermicro last week :)

This code was tested against a H13SSL server.

The implementation is based on the documentation from Supermicro.

Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is awesome! Just need to make the linter happy with a tag to tell it the inclusion of the "cert" is intentional, but looks great. Thanks!

oem/smc/updateservice_test.go Show resolved Hide resolved
@lamaral
Copy link
Contributor Author

lamaral commented Oct 30, 2024

Hi @stmcginnis, I added the tag to the cert.

Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stmcginnis stmcginnis merged commit 5c1df48 into stmcginnis:main Oct 30, 2024
2 checks passed
iamsli pushed a commit to iamsli/gofish that referenced this pull request Dec 2, 2024
@lamaral lamaral deleted the upload branch December 3, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants