fix(stm32CubeProg): fallback to BSD getopt on mac #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
force-pushed
the
getopt
branch
2 times, most recently
from
439a07d
to
4020213
Compare
fpistm
force-pushed
the
getopt
branch
2 times, most recently
from
8fee15e
to
1c5f1bd
Compare
lhvy
reviewed
Jul 17, 2024
| if ! command -v $STM32CP_CLI >/dev/null 2>&1; then | ||
| aborting | ||
| fi | ||
| if ! command -v /usr/local/opt/gnu-getopt/bin/getopt >/dev/null 2>&1; then |
There was a problem hiding this comment.
By the way, for Apple Silicon devices, the path should be /opt/homebrew/opt/gnu-getopt/, maybe this needs to be checked as well?
There was a problem hiding this comment.
Hi @lhvy
Thanks for the feedback, I'm not familiar with mac.
So something like this:
if ! command -v /usr/local/opt/gnu-getopt/bin/getopt >/dev/null 2>&1; then
if ! command -v /opt/homebrew/opt/gnu-getopt/bin/getopt >/dev/null 2>&1; then
echo "Warning: long options not supported due to getopt from FreeBSD usage."
GNU_GETOPT=n
else
export PATH="/opt/homebrew/opt/gnu-getopt/bin":"$PATH"
fi
else
export PATH="/usr/local/opt/gnu-getopt/bin":"$PATH"
fiBy default, MacOS uses getopt from FreeBSD and not the GNU-based one. Then "-o" and long options are not supported except if gnu-getopt is installed. Fixes stm32duino#99 Signed-off-by: Frederic Pillon <[email protected]>
fpistm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, MacOS uses getopt from FreeBSD and not the GNU-based one.
Then "-o" and long options are not supported except if gnu-getopt is installed.
Fixes #99
Main advantage to kept GNU getopt by default is it is able to deal with space in arguments.
Install the package
gnu-getoptvia e.g. Homebrew:If not installed the BSD getopt is used but long option and space in arguments are not supported.