[Arduino compatibility] Ax pin definition #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
force-pushed
the
arduino_compatibility_pin_140
branch
from
92eeacb to
c8cdb46
Compare
|
Can't help feeling that converting from an enum to uint8_t for Somewhat unrelated to this PR, but in the same files: |
lacklustrlabs
approved these changes
Jan 27, 2018
|
I think enum could be kept but at this time I will kept legacy code. |
Ax definition is now inline with Arduino style Variant has only to define the digital pin number of the first analog input (i.e. which digital pin is A0) Clean variant header include Fix stm32duino#140 Signed-off-by: Frederic Pillon <[email protected]>
fpistm
force-pushed
the
arduino_compatibility_pin_140
branch
from
c8cdb46 to
c4c9f48
Compare
benwaffle
pushed a commit
to benwaffle/Arduino_Core_STM32
that referenced
this pull request
Apr 10, 2019
…in_140 [Arduino compatibility] Ax pin definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ax definition is now inline with Arduino style
Variant has only to define the digital pin number of the first analog input (i.e. which digital pin is A0)
Clean variant header include
Fix #140