Added CRC peripheral #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hit the following compiler bug when trying to optimize data into word writes into the CRC peripheral: rust-lang/rust#41775 If anyone has a workaround it'd be appreciated. |
|
Ready for review |
|
LGTM. What are the implications of the compiler bug? Am I right in thinking it only corrupts the debug info for that one function? |
|
@MabezDev Yeah, it corrupts the debug info. |
|
Ah okay. Looks great, won't be able to test on hw, but I trust its all working! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a little bit WIP, I will finalize this tomorrow.