improve spi traits

[andrewgazelka]

• rename to SPI traits to possibly better names

  • SpiAll -> HalSpi
  • SpiEnabled -> HalEnabledSpi
  • SpiDisabled -> HalDisabledSpi

• reset no longer needs to take ownership of the given SPI peripheral

[richardeoin]

The rename seems fine, thanks! I agree that the reset method should use a &mut self receiver, but your implementation seems a bit extreme. My suggestion would be instead:

• Move the implementation from the trait to the ordinary API, so that the reset method is available even when not using the traits
• Add a private method like fn internal_disable(&mut self) that contains the register writes, and use that method in both the pub fn disable(self) and pub fn reset(&mut self) methods. If you like, private methods can be implemented for both typestates (inside impl<EN> Spi<$SPIX, EN, $TY> { ... }) whilst keeping the external typestate API.

[richardeoin]

Looks good now, thanks!

[richardeoin]

bors r+

[bors]

Build succeeded:

• ci (1.52.0, stm32h735)
• ci (1.52.0, stm32h743)
• ci (1.52.0, stm32h743v)
• ci (1.52.0, stm32h747cm7)
• ci (1.52.0, stm32h753)
• ci (1.52.0, stm32h753v)
• ci (1.52.0, stm32h7b0)
• ci (1.52.0, stm32h7b3)
• ci (stable, stm32h735)
• ci (stable, stm32h743)
• ci (stable, stm32h743v)
• ci (stable, stm32h747cm7)
• ci (stable, stm32h753)
• ci (stable, stm32h753v)
• ci (stable, stm32h7b0)
• ci (stable, stm32h7b3)
• Rustfmt