Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Option bytes on the STM32F767 ZIT6 Nucleo-144 #997

Merged
merged 14 commits into from
Jul 19, 2020
Merged

[feature] Option bytes on the STM32F767 ZIT6 Nucleo-144 #997

merged 14 commits into from
Jul 19, 2020

Conversation

rutgerhendriks
Copy link
Contributor

This PR adds --area=option_bytes_boot_add, --area=optcr and --area=optcr1 for the STM32F767 ZI

rutgerhendriks and others added 2 commits May 27, 2020 15:59
…his adds --area=option_boot_add, --area=optcr and --area=optcr1
@Nightwalker-87 Nightwalker-87 self-requested a review June 25, 2020 09:11
@Nightwalker-87 Nightwalker-87 added this to the v1.6.2 milestone Jun 25, 2020
@Nightwalker-87 Nightwalker-87 linked an issue Jun 25, 2020 that may be closed by this pull request
6 tasks
@Nightwalker-87 Nightwalker-87 changed the title PR for [feature] Option bytes on the STM32F767 ZIT6 Nucleo-144 #968 [feature] Option bytes on the STM32F767 ZIT6 Nucleo-144 Jun 25, 2020
@rutgerhendriks
Copy link
Contributor Author

rutgerhendriks commented Jun 25, 2020

Nightwalker-87 thanks for the tip, I'll merge it again so it is clean

@Nightwalker-87 Nightwalker-87 self-requested a review June 26, 2020 22:16
Copy link
Collaborator

@grevaillot grevaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some bits here might need some change - but a proper full rebase would be nice too

src/stlink-lib/usb.c Outdated Show resolved Hide resolved
src/st-flash/flash.h Show resolved Hide resolved
src/st-flash/flash.c Outdated Show resolved Hide resolved
inc/stlink.h Show resolved Hide resolved
src/st-flash/flash.c Outdated Show resolved Hide resolved
@Nightwalker-87
Copy link
Member

@grevaillot: I can remember that you intended or considered to contribute for the H7 from a personal feature branch earlier. So I absolutely don't mind if you take part in this discussion and bring in some helpful suggestions. If you fancy, you can also assign yourself to this topic (again).

@Nightwalker-87
Copy link
Member

@rutgerhendriks: Can you have another look at this as soon as you find time?

@rutgerhendriks
Copy link
Contributor Author

rutgerhendriks commented Jul 2, 2020 via email

@Nightwalker-87
Copy link
Member

@rutgerhendriks: There are still some open points to address. Can you have a look?

@rutgerhendriks
Copy link
Contributor Author

The build is clean now and I closed the comments. I think it's ready to be merged now, right?

@Nightwalker-87
Copy link
Member

The build is clean now and I closed the comments. I think it's ready to be merged now, right?

We're almost there, yes. Thx for solving this main compilation issue. 👍

@Nightwalker-87 Nightwalker-87 merged commit f162a5d into stlink-org:develop Jul 19, 2020
@Nightwalker-87
Copy link
Member

@rutgerhendriks: Thank you very much for your contribution! 👍

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feature] Option bytes on the STM32F767 ZIT6 Nucleo-144
3 participants