-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
st-trace: Fixed clock issues #1252
Merged
Nightwalker-87
merged 1 commit into
stlink-org:develop
from
simplerobot:john-trace-clock-issues
Jul 14, 2022
Merged
st-trace: Fixed clock issues #1252
Nightwalker-87
merged 1 commit into
stlink-org:develop
from
simplerobot:john-trace-clock-issues
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightwalker-87
requested changes
Jun 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
Making sure trace frequency is not less than 1/5 of the system frequency. Showing minimum and maximum available trace speed when out of range. Making sure MCU is stopped after reset to avoid missing data. Making sure variables are intiallized.
simplerobot
force-pushed
the
john-trace-clock-issues
branch
from
June 8, 2022 20:49
8be8a7b
to
f8d1603
Compare
I've updated as you requested. (Also squashed changes into a single commit.) |
Nightwalker-87
approved these changes
Jun 9, 2022
Nightwalker-87
changed the title
[st-trace] Fixed clock issues
st-trace: Fixed clock issues
Jul 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed register read to use the right register for TPI_ACPR.
Updating to expect frequency units for clock and trace flags.
Making sure trace frequency is not less than 1/5 of the system frequency.