Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st-trace: Fixed clock issues #1252

Merged

Conversation

simplerobot
Copy link
Collaborator

Fixed register read to use the right register for TPI_ACPR.
Updating to expect frequency units for clock and trace flags.
Making sure trace frequency is not less than 1/5 of the system frequency.

src/st-trace/trace.c Outdated Show resolved Hide resolved
Copy link
Member

@Nightwalker-87 Nightwalker-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

src/st-trace/trace.c Outdated Show resolved Hide resolved
@Nightwalker-87 Nightwalker-87 changed the title John trace clock issues st-trace clock issues Jun 4, 2022
Making sure trace frequency is not less than 1/5 of the system frequency.
Showing minimum and maximum available trace speed when out of range.
Making sure MCU is stopped after reset to avoid missing data.
Making sure variables are intiallized.
@simplerobot
Copy link
Collaborator Author

simplerobot commented Jun 8, 2022

I've updated as you requested. (Also squashed changes into a single commit.)

@Nightwalker-87 Nightwalker-87 changed the title st-trace clock issues [st-trace] clock issues Jul 14, 2022
@Nightwalker-87 Nightwalker-87 merged commit 254a525 into stlink-org:develop Jul 14, 2022
@Nightwalker-87 Nightwalker-87 changed the title [st-trace] clock issues [st-trace] Fixed clock issues Jul 14, 2022
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Jul 14, 2022
@Nightwalker-87 Nightwalker-87 changed the title [st-trace] Fixed clock issues st-trace: Fixed clock issues Jul 14, 2022
@simplerobot simplerobot deleted the john-trace-clock-issues branch July 16, 2022 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

st-trace: Synchronization issue
2 participants