Fixed old DFU serial number for STLINK programmers

[tarek-bochkati]

Signed-off-by: Tarek BOCHKATI [email protected]

(Closes #417, Closes #494, Closes #1121)

[Ant-ON]

For the "--- serial" parameter work correctly is necessary to rewrite the parsing of the serial number. See:

stlink/src/st-util/gdb-server.c

Lines 198 to 207 in cc9bedd

	int j = (int)strlen(optarg);
	int length = j / 2; // the length of the destination-array
	if (j % 2 != 0) { return(-1); }
	for (size_t k = 0; j >= 0 && k < sizeof(serialnumber); ++k, j -= 2) {
	char buffer[3] = {0};
	memcpy(buffer, optarg + j, 2);
	serialnumber[length - k] = (uint8_t)strtol(buffer, NULL, 16);
	}

stlink/src/st-flash/flash_opts.c

Lines 111 to 120 in cc9bedd

	int j = (int)strlen(serial);
	int length = j / 2; // the length of the destination-array
	if (j % 2 != 0) { return(-1); }
	for (size_t k = 0; j >= 0 && k < sizeof(o->serial); ++k, j -= 2) {
	char buffer[3] = {0};
	memcpy(buffer, serial + j, 2);
	o->serial[length - k] = (uint8_t)strtol(buffer, NULL, 16);
	}

[Nightwalker-87]

There also is a build fail on macOS, but it looks as if this is related to the current CI config for macOS
I'll fix that soon, and we'll have a look at it again afterwards, so don't bother too much about it right now. 😉

[tarek-bochkati]

There also is a build fail on macOS, but it looks as if this is related to the current CI config for macOS
I'll fix that soon, and we'll have a look at it again afterwards, so don't bother too much about it right now. 😉

I have seen the failure log, so I already ignored it ...

[tarek-bochkati]

For the "--- serial" parameter work correctly is necessary to rewrite the parsing of the serial number.
shit! this should be handled in one place ...

I will check it tonight

[Nightwalker-87]

I've updated the Travis CI settings for macOS.
However there are still problems with the build on 10.14 and it still seems to be a lousy Xcode related issue. 🤮

[tarek-bochkati]

another Patch-Set is pushed, please let me know if this is OK.

[tarek-bochkati]

I've updated the Travis CI settings for macOS.
However there are still problems with the build on 10.14 and it still seems to be a lousy Xcode related issue. 🤮

still failing on macos :/

[Nightwalker-87]

Yeah, I'm still trying to solve it. It's not specifically related to this PR, but also other commits / PRs.

[tarek-bochkati]

happy to see this approved and solved your issue.
and good luck with STM32U5 support 😨

[Nightwalker-87]

@tarek-bochkati: I'll merge this as soon as possible.
Thank you so much for contributing. May I add you to our list of project contributors?
Looking forward to stay in touch.

[tarek-bochkati]

@tarek-bochkati: I'll merge this as soon as possible.
Thank you so much for contributing. May I add you to our list of project contributors?
Looking forward to stay in touch.

honestly I don't plan to be an active contributor in this project.
but I'm watching the evolution here and I can contribute time to time (my main focus is contributing to OpenOCD as part of my job)

[Nightwalker-87]

That's absolutely fine - there are no expectations associated with this.
For explanation: Our list of contributors is part of the project source code and aims to cover people who have brought notable improvements to the project pointing out the character of a community based project.

[tarek-bochkati]

Then we agree on this ;)