Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSONArrayTest testRecursiveDepthArrayFor1000Levels() #855

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

stleary
Copy link
Owner

@stleary stleary commented Feb 2, 2024

Description
JSONArrayTest testRecursiveDepthArrayFor1000Levels() has been failing intermittently in the Java 11 compile/test step. Recently it started failing continuously. This change catches and ignores the StackOverflowError only when running with Java 11.

Refactoring
None

Testing done
Confirmed expected results with Java 11 and other Java versions

Note
Currently none of the other recursive depth tests are failing, but similar changes may be made if they do start occurring.

@stleary
Copy link
Owner Author

stleary commented Feb 2, 2024

What problem does this code solve?
Intermittent StackOverflowError test failures when running with Java 11.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, it fixes an intermittently failing unit test

Was any code refactored in this commit?
No

Review status
APPROVED - by myself

Starting 3-day comment window

@stleary stleary merged commit f0308a3 into master Feb 5, 2024
12 checks passed
@stleary stleary changed the title Fixing JSONArrayTest testRecursiveDepthArrayFor1000Levels() Fix JSONArrayTest testRecursiveDepthArrayFor1000Levels() Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant