Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create unit tests for various number formats #691

Conversation

hendrixjoseph
Copy link

For issue #657 Unit tests should check various number formats

This adds tests for various number formats (namely: decimal with and without a decimal point, exponent with both capital and lowercase E, both in the positive and negative) for the various get* and opt* number methods of JSONObject.

It does NOT add hex, floating point hex, or octal, as these are not supported JSON features (see https://stackoverflow.com/a/52671839/6323312). JSONObject also does not support hex, floating point hex, or octal.

I can add these additional number format tests if wanted, though.

@stleary
Copy link
Owner

stleary commented Oct 4, 2022

What problem does this code solve?
Adds some missing unit tests.

Risks
Low

Changes to the API?
N/A

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
N/A

Review status
APPROVED

Starting 3 day comment window

@stleary stleary merged commit 444335d into stleary:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants