Fix problem with precision when retrieving BigDecimal JSON properties. #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is now, retrieving a property with value "0.01" with `JSONObject.getBigDecimal(key)` will return "0.01000000000000000020816681711721685132943093776702880859375" instead "0.01".
|
Breaks unit tests. Please see https://github.com/stleary/JSON-Java-unit-test |
|
@sollecitom Thanks for the pull request, it is appreciated. This project is in maintenance mode, so most changes are user-driven. We ask that code submitters follow the process from end to end, which includes ensuring the unit tests pass, as described in this wiki page: https://github.com/stleary/JSON-java/wiki/How-to-contribute-code-for-this-project Breakages may indicate a change in behavior to existing code. When that happens, we have to determine if fixing the problem is more urgent than potentially breaking existing applications. You can find more information about this in the FAQ. |
|
Closed for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now, retrieving a property with value "0.01" with
JSONObject.getBigDecimal(key)will return "0.01000000000000000020816681711721685132943093776702880859375" instead "0.01".