An omnibus of improvements #131
Open
+265,060
−5,185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding support for first-class functions. - Improved error formatting following GNU standard. Todo: - Use the cast function for all casts in the VM. Check for casts in parsers, Eve, and Adam that could also be improved. - Investigate the snipped feature for errors and remove or improve it. - Support cascading error reporting, not just backtrace data. - Embed line/position information in the expression sequence to improve error reporting. - Are there places where errors could be reported as a range?
- Removing vspkg in favor of CMake for boost dependency. Cleaning up sha code use of size_t vs uint64_t.
…b/adobe_source_libraries into sean-parent/experimental-vm
- Improved type mismatch error messages. - Better windows launch support in VSCode - added promote_t<T> as alias for promote<T>::type.
adam.hpp - rename `get` to `cell_value` - result is now an `optional` fixed bugs in lex improved error reporting and bug fix on line tracking more work on first class functions and improving function lookup. added unit test for expression_parser (currently just a shell).
Adding better error reporting and cleaning up parser code.
- improved error reporting - code simplified
- start of clang-tidy support (issues with copy_on_write but plan to move to stlab/libraries copy_on_write after this PR. - removed the `unit_test` directory - moving all tests into the `test` directory. - completed error tests for expression parser - fixed additional bugs in expression parser error reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (breaking):
std.<function-name>, i.e.,std.min(a, b, c)sheet_t::get()has been renamedsheet_t::cell_value()and now returns an optional instead of throwing an exception if the named cell is not found.Improvements:
lex_streamandexpression_parser.Project Structure:
unit_testdirectory moved into parenttestdirectory.Numerous code improvements and bug fixes. Start of clang-tidy support (holding off until I remove overlapping libraries in favor of stlab libraries).