feat: automatically install Sprocket from GitHub releases. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a feature to the VSCode extension to automatically download the latest stable Sprocket from GitHub releases. It does this by first querying `crates.io` for the latest stable `sprocket` crate version; it then fetches the GitHub release artifact corresponding to that version. The extension will also check for newer versions to what has been previously downloaded and prompt to download and update to the next version. A new setting has been added to control checking for updates on startup.
|
I need to test this on Linux and Windows, but it's working well on macOS. This should hopefully make it both easier to use the VSCode extension and to get notified to update when Sprocket releases occur. |
This commit refactors the installation code to be a little more readable.
Also fixes: * SVG isn't allowed from the marketplace when building the extension. * The asset path doesn't like the `./` prefix when building the extension.
a-frantz
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature to the VSCode extension to automatically download
the latest stable Sprocket from GitHub releases.
It does this by first querying
crates.iofor the latest stablesprocketcrate version; it then fetches the GitHub release artifact corresponding to
that version.
The extension will also check for newer versions to what has been previously
downloaded and prompt to download and update to the next version.
A new setting has been added to control checking for updates on startup.