Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #9, #10, and #11 #12

Merged
merged 1 commit into from
Feb 13, 2016
Merged

Fixing #9, #10, and #11 #12

merged 1 commit into from
Feb 13, 2016

Conversation

stjohnjohnson
Copy link
Owner

@jer

@stjohnjohnson
Switching default preface to smartthings instead of /smartthings …
c3b6392 
…but leaving backwards compatibility (fixes #10)

Adding saving of history to disk, to prevent startup spam (partial fix for #9)
Do not send level if current state is "off" (fixes #9)
Resubscribe to topics if connection with MQTT is lost (fixes #11)
jer
jer reviewed Feb 13, 2016
View reviewed changes
README.md

For example, my Dimmer Z-Wave Lamp is called "Fireplace Lights" in SmartThings. The following topics are published:

```
# Brightness (0-99)
/smartthings/Fireplace Lights/level
smartthings/Fireplace Lights/level
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you get rid of the '/'?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answering my own question: http://www.hivemq.com/blog/mqtt-essentials-part-5-mqtt-topics-best-practices

@jer
Copy link
Collaborator

jer commented Feb 13, 2016

States EVERYWHERE!

👍

stjohnjohnson added a commit that referenced this pull request Feb 13, 2016
@stjohnjohnson
Merge pull request #12 from stjohnjohnson/ForwardsCompatible
b20a518 
Fixing #9, #10, and #11
@stjohnjohnson stjohnjohnson merged commit b20a518 into master Feb 13, 2016
@stjohnjohnson stjohnjohnson deleted the ForwardsCompatible branch February 13, 2016 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jer jer

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stjohnjohnson @jer