Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Bump NYC and Mocha to latest version #43

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

Zaky7
Copy link
Contributor

@Zaky7 Zaky7 commented Mar 19, 2020

Updated two packages for resolving the vulnerability

nyc

nyc updatd from v14.1.1 to v15.0.0 for resolving handlebars vulnerability

mocha

mocha updated from v6.0.0 to v7.0.0 for resolving minimist vulnerability

@Zaky7
Copy link
Contributor Author

Zaky7 commented Mar 19, 2020

@stjohnjohnson FYI

@brettz9
Copy link

brettz9 commented Mar 20, 2020

Note that this fixes #42

@redonkulus
Copy link
Contributor

@Zaky7 mocha just released 8.x, want to upgrade to that?

@stjohnjohnson want to give me access to merge and publish to npm???

@Zaky7
Copy link
Contributor Author

Zaky7 commented Jun 12, 2020

@redonkulus Mocha has significantly changed the API for version 8 with breaking changes. I think we should first merge version 7 in Jenkins-mocha, then you can create another PR for merging Version 8 of mocha.

@avik-so avik-so mentioned this pull request Jun 26, 2020
@avik-so
Copy link

avik-so commented Jun 26, 2020

@redonkulus Mocha has significantly changed the API for version 8 with breaking changes. I think we should first merge version 7 in Jenkins-mocha, then you can create another PR for merging Version 8 of mocha.

I created a PR here: #44

@dskrvk
Copy link

dskrvk commented Feb 9, 2022

It would be great to see this merged and published. What's blocking this?

@stjohnjohnson stjohnjohnson merged commit bb3ebeb into stjohnjohnson:master Mar 7, 2022
@stjohnjohnson
Copy link
Owner

Sorry for the delay, published https://www.npmjs.com/package/jenkins-mocha/v/9.0.0

@stjohnjohnson
Copy link
Owner

Let me know if you have Mocha 8 and Mocha 9 PRs. I'll try to review and publish quickly.

@brettz9 brettz9 mentioned this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants