Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Adds warning to show Hamilton is enabled #302

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Feb 3, 2023

Just to make it clear to people telemetry is enable, with a pointer to get more information on it.

Changes

  • adds warning statement on first time someone checks if telemetry is used.

How I tested this

N/A

Notes

I think this is useful to have to ensure people know what is happening.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Just to make it clear to people telemetry is enable, with a pointer
to get more information on it.
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skrawcz skrawcz merged commit 507ad15 into main Feb 3, 2023
@skrawcz skrawcz deleted the add_telemetry_on_statement branch February 3, 2023 00:08
@skrawcz skrawcz mentioned this pull request Feb 3, 2023
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants