Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close keyframe block on getStyles #202

Merged
merged 6 commits into from
Sep 10, 2020
Merged

Conversation

cometkim
Copy link
Contributor

@cometkim cometkim commented Sep 9, 2020

Fixes #200

@cometkim cometkim requested a review from peduarte September 9, 2020 16:01
@peduarte peduarte mentioned this pull request Sep 9, 2020
@peduarte
Copy link
Contributor

peduarte commented Sep 9, 2020

@cometkim Thanks for this <3

While we're still improving our CI workflow and PRs arent running tests. Can you confirm that you can do these succesfully:

  • yarn test
  • yarn build

Otherwise this PR looks good to me!

@cometkim
Copy link
Contributor Author

cometkim commented Sep 9, 2020

image

@peduarte tests are all green (but build?)

and build is ok

image

@peduarte
Copy link
Contributor

peduarte commented Sep 9, 2020

@cometkim one last thing, I implemetned CodeSandbox CI in #198

But it's not working here because your branch doesn't have the latest code from canary

Can you update this branch, and push, so I can validate everything is working on CodeSandbox?

Sorry, gotta be extra cautious while we don't have a decent CI in place :)

@cometkim
Copy link
Contributor Author

cometkim commented Sep 9, 2020

forgot to rebase 😅

@peduarte
Copy link
Contributor

peduarte commented Sep 9, 2020

@cometkim ok looks like CodeSandbox is trying to build the packages, let's see. Seems to be stuck 😅

It worked here #198

@cometkim
Copy link
Contributor Author

cometkim commented Sep 9, 2020

Haha no worries, I can wait. slow CIs give me a break XD

@vivek12345
Copy link
Contributor

looks like some issue with codesandbox ci

@cometkim
Copy link
Contributor Author

cometkim commented Sep 9, 2020

image

lol

@peduarte
Copy link
Contributor

peduarte commented Sep 9, 2020

I'm on my phone now so can't do much. Is it an issue with codesandbox or with our integration?

Can we try doing another commit?

@cometkim
Copy link
Contributor Author

cometkim commented Sep 9, 2020

No, I think the codesandbox (at least the CI service) is down now. It was running well until it started to respond bad gateway.

I gonna sleep today. I will check maybe 9 hours later :)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 451e6e2:

Sandbox Source
Stitches CI: Next.js Configuration
Stitches CI: CRA Configuration

@cometkim
Copy link
Contributor Author

@peduarte

@peduarte
Copy link
Contributor

@cometkim great work, thank you

@peduarte peduarte merged commit f599fa4 into stitchesjs:canary Sep 10, 2020
@cometkim cometkim deleted the gh-200 branch September 10, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getStyles() does not close keyframes block
3 participants