-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Close keyframe block on getStyles #202
Conversation
@cometkim Thanks for this <3 While we're still improving our CI workflow and PRs arent running tests. Can you confirm that you can do these succesfully:
Otherwise this PR looks good to me! |
@peduarte tests are all green and build is ok |
@cometkim one last thing, I implemetned CodeSandbox CI in #198 But it's not working here because your branch doesn't have the latest code from Can you update this branch, and push, so I can validate everything is working on CodeSandbox? Sorry, gotta be extra cautious while we don't have a decent CI in place :) |
forgot to rebase 😅 |
Haha no worries, I can wait. slow CIs give me a break XD |
looks like some issue with codesandbox ci |
I'm on my phone now so can't do much. Is it an issue with codesandbox or with our integration? Can we try doing another commit? |
No, I think the codesandbox (at least the CI service) is down now. It was running well until it started to respond bad gateway. I gonna sleep today. I will check maybe 9 hours later :) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 451e6e2:
|
@cometkim great work, thank you |
Fixes #200