Strict mode #116
Closed
Strict mode #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 19, 2020 16:18
With this change the compiler will yield an error when tokens are defined but raw values are used instead. In order to use non-token values developers must add `as any` or `@ts-ignore`. https://twitter.com/fgnass/status/1296034855562743808
This change allows the use of non-token values if no tokens are defined for the corresponding category.
Adds a strict flag as discussed in #108
peduarte
reviewed
Aug 20, 2020
| }); | ||
| css({ | ||
| color: "primary", | ||
| // @ts-ignore |
There was a problem hiding this comment.
I saw in a diff PR you used @ts-expect-error. just wondering if its also worth using it here instead of a @ts-ignore?
There was a problem hiding this comment.
I had @ts-expect-error here first but for some reason the tests then failed, even though the build succeeded. I didn't investigate further why things are different when running through ts-jest and opted for this quick fix.
|
@fgnass hey. sorry for the delay on this. we had to put it on hold, as we were getting ready to officially launch stitches. I'm keen on getting this in for the next release. we need to:
Thanks! |
|
Closing in favour of #206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #108 this PR adds a strict flag to the config.