Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require ostruct for StimulusReflex::Dataset #697

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

marcoroth
Copy link
Member

@marcoroth marcoroth commented Apr 26, 2024

Type of PR

Bug Fix

Description

From #695:

Rubocop v1.63.0 updates json to v2.7.2. json v2.7.2 ruby/json#565. StimulusReflex relies on OpenStruct in both the Dataset and the Element models. Attempting to run rails, ie a rails console, results in the error

Fixes #695

Why should this be added

Makes applications and CI run again.

We should think about migrating off of OpenStruct, but this PR should make it work for now as a work-around.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for stimulusreflex ready!

Name Link
🔨 Latest commit 9959149
🔍 Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/662c19d714e7df0008d8a2da
😎 Deploy Preview https://deploy-preview-697--stimulusreflex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcoroth marcoroth merged commit 3f1b030 into main Apr 26, 2024
18 checks passed
@marcoroth marcoroth deleted the fix-openstruct-require branch April 26, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenStruct no longer supported by json
1 participant