Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract StimulusReflex::Fragment #594

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Extract StimulusReflex::Fragment #594

merged 3 commits into from
Jul 13, 2022

Conversation

julianrubisch
Copy link
Contributor

Enhancement

Description

In preparation of a few things I'd like to try out, I found that it'd make sense to create a Fragment wrapper around Nokogiri::Fragment. In addition to just wrapping, it provides simplified access to Matches

I think even more functionality could find its place here, but I wanted to keep it simple at first.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️

@julianrubisch julianrubisch added the enhancement New feature or request label Jul 13, 2022
@julianrubisch julianrubisch self-assigned this Jul 13, 2022
Copy link
Contributor

@leastbad leastbad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM with the caveat that I haven't run it personally.

Excited to see what you do with this.

@leastbad leastbad merged commit 1f99e9c into master Jul 13, 2022
@leastbad leastbad deleted the extract-fragment branch July 13, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants