Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflex render layout defaults to false #534

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

leastbad
Copy link
Contributor

Type of PR (feature, enhancement, bug fix, etc.)

Enhancement

Description

Reflex render method now defaults to layout: false.

Why should this be added

Discord user @jsantos was having issues with AuthLogic when rendering a template using a Nothing Morph. It was determined that render calls initiated inside of Reflex classes should default to layout: false.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

@leastbad leastbad added enhancement New feature or request proposal ruby Pull requests that update Ruby code labels Jul 27, 2021
@leastbad leastbad added this to the 3.5 milestone Jul 27, 2021
@leastbad leastbad requested a review from hopsoft July 27, 2021 17:03
@leastbad leastbad self-assigned this Jul 27, 2021
@leastbad leastbad merged commit f1d2b33 into stimulusreflex:master Aug 11, 2021
@leastbad leastbad deleted the suppress_layout branch August 11, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants