tab_id accessor #506
Merged
tab_id accessor #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leastbad
added
enhancement
marcoroth
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Enhancement
Description
Reflex class gains a
tab_idaccessor to complimentreflex_id. It is a UUIDv4 that is generated every time SR is initialized, eg once per tab. Refreshes and different/duplicated tabs will have different values.Part of the ClientAttributes struct.
Updated the generator template to reflect this new accessor.
Why should this be added
Sometimes, I really wish that I had a way of uniquely identifying the browser tab which made a request without having to pack it into a data attribute. It's especially significant for an upcoming gem I'm working on.
Checklist