Factor reflex creation and reflex data management out of channel #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrubisch
force-pushed
the
restructure-receive
branch
from
02f3b1c
to
ee9a75e
Compare
julianrubisch
changed the title
julianrubisch
commented
Apr 8, 2021
julianrubisch
force-pushed
the
restructure-receive
branch
from
ee9a75e
to
c524407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Description
Basically most of the attributes derived from the
datahash passed toreceivehave been factored out to an ownReflexDataclass. Furthermore the logic for actually creating the reflex has been moved to aReflexFactory.Why should this be added
This not only makes the class more readable but will also facilitate discussions about what part of it should be public API in an upcoming plugin system
Checklist
Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️