make element.reflexController a dictionary

[existentialmutt]

Type of PR (feature, enhancement, bug fix, etc.)

bug fix

Description

Following up on #377, this PR makes element.reflexController a dictionary to prevent multiple reflexes on the same element from overwriting eachothers' data

Fixes # (issue)

Why should this be added

prevents race conditions when running multiple reflexes on the same element

Checklist

• My code follows the style guidelines of this project
• Checks (StandardRB & Prettier-Standard) are passing
• This is not a documentation update

Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️

[leastbad]

Hey Rafe, another good catch.

My understanding of things is that an element can only have one instance of a controller on it. That means we could solve this "simply" by removing line 56 of lifecycle.js, right?

I'm trying to wrap my head around a scenario where there would be multiple different Reflex controllers on an element with different names. We might have to ask @hopsoft for clarity here.

[existentialmutt]

Good call- I suspect removing delete element.reflexController would do the trick. I'll test that next chance I get.

[hopsoft]

I'll have to think on this a bit harder, but the reason we call delete element.reflexController is to clean up references that might cause memory leaks, so we'd still want to remove any references to controllers embedded in the new dictionary datatype.

[leastbad]

I usually shy away from shotgun solutions, but I have an idea:

if (reflexes.length == 1) delete element.reflexController

The premise here is that if there's only one active Reflex in the dictionary, it's the current one, so you're safe to clear out the controller reference.

[hopsoft]

Makes sense, but I expect that this should be sufficient. delete element.reflexController[reflexId]