-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to supress warnings for sanity checks #359
Allow to supress warnings for sanity checks #359
Conversation
Here this was reported as an issue: https://discord.com/channels/629472241427415060/733725826411135107/773114004666318858 |
620de96
to
c8de1b0
Compare
c8de1b0
to
c2634c0
Compare
One thing that is self-evident from the conversations with both AbuMareBear and Dave Sanders is that there absolutely needs to be a section in the documentation on setting up the Rails test environment so that it can work with the same general configuration used in development. Any actual testing, whether with minitest, RSpec or "does the witch float" could follow. I am concerned that we are optimizing to minimize the annoyance of folks who (innocently and benevolently) haven't set up their test environments. It stands to reason that if they follow some basic, one-time steps, they won't be plagued with errors. Right?
ANYHOW. 😀 I really like the implementation you've come up with. I could be crazy but what you call I'm glad that we're still defaulting to I am going to make a tiny non-functional tweak to the error message to point to the correct location. |
Would be fine for me, but you never know what the future holds. I almost thought to treat everything but |
What do you think? Too much? |
@leastbad Nah, that's nice to offer such clear information. I like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I had one minor nitpick.
Enhancement
Description
Changes
confg.exit_on_failed_sanity_checks
that uses a boolean, toconfig.on_failed_sanity_checks
with three options:exit
,:warn
,:ignore
Some people were seeing the warning on test runs, which can be annoying especially if you are working with TDD. So it would be better to provide an opt out possibility.
Checklist