Fix serializeForm initialization #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default option for `options['serializeForm']` is `undefined`. With `undefined` or `true` the client should serialize the form with `false` you opt-out of the form initialization and it should not send any params to the backend
…nto fix-serializeForm-initialization
marcoroth
changed the title
|
Ugh, this is almost certainly my doing. Thanks for saving the day, again, @marcoroth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Bug fix
Description
@thylacinelol (and probably @acetinick) noted on Discord, that their reflexes using forms stopped working while upgrading to
3.4.0.pre1.The default option for
options['serializeForm']isundefined. With the value ofundefinedortruethe client should serialize the form. With the valuefalseyou opt-out of the form initialization and it should not send any from params to the backend.Currently you had to opt-in with
serializeForm = trueto get it working again. It should be the other way around.This PR fixes this logic.
Why should this be added
The current logic would break backwards compatibility.
Checklist