Proposal: Reduce bundle size and add a bundler for Stimulus Reflex javascript #315
Conversation
KonnorRogers
changed the title
KonnorRogers
changed the title
|
Even your git commit messages are top notch |
Readd the packages as devDependencies so they get installed during development. (PeerDependencies are not automatically installed)
|
FYI: I have great faith in @ParamagicDev but I haven't tested this PR and am not 100% confident I could explain the ramifications to someone in a bar. @hopsoft what is your confidence interval? |
|
@leastbad So here's my $0.02, to start, yes there are trade offs. In summary by moving ActionCable, CableReady, and Stimulus to peerDependencies, it means the user has to install them and it uses whatever the user has installed. If it does not match the version or the peerDependency, it will output a warning to the user when they The trade off is StimulusReflex does not have explicit versioning, however, it also means that users don't have 2 instances of ActionCable, CableReady, and Stimulus if they installed them in their project separate of StimulusReflex. |
|
Thanks to @ParamagicDev, I'm now on a |
Introduce `@cable_ready/polyfills` Move javascript/ to packages/@cable_ready/core Introduce microbundle for the package builds Applies all of the changes from stimulusreflex/stimulus_reflex#340, stimulusreflex/stimulus_reflex#315 and stimulusreflex/stimulus_reflex#345 to cable_ready
This commit enforces users to add `cable_ready` as an explicit dependendcy to their app's `Gemfile` This is to match the behavior introduced in stimulusreflex#315. Moving `cable_ready` to the `peerDependencies` resulted in that users now need to add `cable_ready` as a dependecy to the app's `package.json` Co-Authored-By: paramagicdev <[email protected]>
This commit enforces users to add `cable_ready` as an explicit dependendcy to their app's `Gemfile` This is to match the behavior introduced in stimulusreflex#315. Moving `cable_ready` to the `peerDependencies` resulted in that users now need to add `cable_ready` as a dependecy to the app's `package.json` Co-Authored-By: paramagicdev <[email protected]>
Type of PR (feature, enhancement, bug fix, etc.)
Proposal
Description
Move
@rails/actioncable,stimulus, andcable_readytopeerDependenciesAdd
cable_readyto the install task.Add microbundle to bundle javascript for publishing.
Why should this be added
By moving these
dependenciestopeerDependencies, it will reduce the size of StimulusReflex's package and remove any possible version issues between user defined packages and the packages SR ships.Adding a Bundler helps SR run in different environments.
Checklist