Rails 7.1 support #169
Merged
Rails 7.1 support #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrubisch
force-pushed
the
rails-7.1-support
branch
from
2f050c8 to
e20ee31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two changes to ActionPack that were breaking futurism's Rails 7.1 compatibility:
MessageVerifier Serializer
The default Rails message verifier serializer has been changed from
MarshaltoJSON(see https://github.com/rails/rails/blob/7-1-stable/activesupport/CHANGELOG.md). This resulted in deserialization into a hash with stringified keys, breaking a couple of tests.ActionController::Renderer
For some reason, ActionController::Renderer now messes with the
SCRIPT_NAMEof the@envvariable. I'm not totally sure, but I think it's related to this PR: rails/rails#46649. This surfaced in a couple of tests because a "blank" url ("") was passed tosetup_env!here: https://github.com/stimulusreflex/futurism/pull/169/files#diff-4ed78c4b57d45045cfecc7dee4ad1eae03ead2293b24414d7ff1ad08f3764bb9R36, resulting inSCRIPT_NAMEnot being set on our name. This was likely a bug in the first place, because we only need to guard against thenilcase.