Ship prebuilt js with gem #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrubisch
force-pushed
the
ship-prebuilt-js-with-gem
branch
from
b04a3a7 to
05e6dac
Compare
julianrubisch
force-pushed
the
ship-prebuilt-js-with-gem
branch
from
05e6dac to
600518f
Compare
marcoroth
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Looks good to me!
The only thing you could think about is being more specific about which files you want to include in your gem, in the gemspec.
Line 17 in 4532750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analoguous to stimulusreflex/stimulus_reflex#575 and stimulusreflex/cable_ready#191, sets up the JS pipeline for shipping prebuilt bundles