Update to debian stretch #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian has dropped support for jessie, which is the default base image for
node:8.This means that any
apt-get updatecommands will fail because thejessie-updatesrepository no longer exists.The default base image for
node:9andnode:10is stretch, it's onlynode:8that's a problem. It looks like this will be updated pretty soon though, according to nodejs/docker-node#1013.I've manually built the three images using my changes and tested that they work fine. This shouldn't break anything, though I can't promise there won't be backwards incompatible changes if anyone using this image jessie specific features or repositories (though you should definitely not be doing this anymore since it's unsupported).