Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not working with psr/simple-cache v3 #1

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix: not working with psr/simple-cache v3 #1

merged 1 commit into from
Nov 29, 2022

Conversation

stickeepaul
Copy link
Collaborator

@stickeepaul stickeepaul commented Nov 29, 2022

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change?
Fixes Laravel Excel not working with Laravel 9 because Laravel 9 installs psr/simple-cache v3 and Laravel Excel is not compatible with v3.

This PR is the same as PR 3733 which was closed because:

Sorry this is not an option, this will introduce too many breaking changes for now

Another issue mentions:

This package doesn't require outdated versions, however PhpSpreadsheet doesn't support the newest version of the simple-cache interfaces yet (Laravel supports v1, 2 and 3, but composer will always install the latest first if no other dependency needs a lower one).

I believe PhpSpreadsheet also needed updating (3057) to v1.25.0 which has now happened, and so this PR also raises the minimum version for that dependency.

Fixes issues:

  • 3805
  • 3787
  • 3758
  • 3755
  • 3743
  • 3738
  • 3731
  • 3718
  • 3668
  • 3611
  • 3576
  • 3535

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.

3️⃣ Does it include tests, if possible?
No.

4️⃣ Any drawbacks? Possible breaking changes?
Will no longer support PHP 7.4 (PHP 7.4 is no longer supported)

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
    • it was closed
  • Added tests to ensure against regression.
    • it's a fix
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@stickeepaul stickeepaul merged commit 392ac79 into 3.1 Nov 29, 2022
@stickeepaul stickeepaul deleted the fix/php-8 branch November 29, 2022 11:15
@stickeepaul
Copy link
Collaborator Author

I merged this into the 3.1 branch and it should have been the 4.0 branch.

Keeping this PR as a reference but the commit no longer exists in 3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants