Merge pull request #7 from MrRio/master

lineWidth should be nonnegative (parallax#3132)
sthagen · Apr 11, 2021 · 1a93365 · 1a93365
2 parents b59aac9 + cbc85b4
commit 1a93365
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/modules/context2d.js b/src/modules/context2d.js
@@ -1722,7 +1722,7 @@ import {
     var strokeStyle = this.strokeStyle;
     var lineCap = this.lineCap;
     var oldLineWidth = this.lineWidth;
-    var lineWidth = oldLineWidth * this.ctx.transform.scaleX;
+    var lineWidth = Math.abs(oldLineWidth * this.ctx.transform.scaleX);
     var lineJoin = this.lineJoin;
 
     var origPath = JSON.parse(JSON.stringify(this.path));

diff --git a/test/specs/context2d.spec.js b/test/specs/context2d.spec.js
@@ -555,4 +555,32 @@ describe("Context2D: standard tests", () => {
 
     comparePdf(doc.output(), "autoPaging10Pages.pdf", "context2d");
   });
+
+  it("lineWidth should be nonnegative", ()=>{
+    var doc = new jsPDF({
+      orientation: "p",
+      unit: "pt",
+      format: "a4",
+      floatPrecision: 3
+    });
+    var ctx = doc.context2d;
+    var writeArray = [];
+    doc.__private__.setCustomOutputDestination(writeArray);
+
+    ctx.beginPath();
+    ctx.strokeStyle = "#FF0000";
+    ctx.transform(-1, 0, 0, 1, 0, 0);
+    ctx.moveTo(0, 0);
+    ctx.lineTo(100, 100);
+    ctx.stroke();
+
+    expect(writeArray).toEqual([
+      "1. 0. 0. RG",
+      "1. w", // <- should be nonnegative
+      "0. 841.89 m",
+      "-100. 741.89 l",
+      "S",
+      "1. w"
+    ]);
+  });
 });