Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[headermap] speedup for appending data (#8029) #10

Merged
merged 1 commit into from
Aug 25, 2019
Merged

[headermap] speedup for appending data (#8029) #10

merged 1 commit into from
Aug 25, 2019

Commits on Aug 25, 2019

  1. [headermap] speedup for appending data (#8029) 

    For debug builds, performance testing and fuzzers reveal that when appending to a header, we scan both the existing value and the data to append for invalid characters. This PR moves the validation check to just the data that is appended, to avoid hangups on re-scanning long header values multiple times.

Testing: Added corpus entry that reveals time spent in validHeaderString

Signed-off-by: Asra Ali <[email protected]>
    @asraa @htuch
    asraa authored and htuch committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    6ff0bce View commit details
    Browse the repository at this point in the history