Feat/secure guest #986
Open
Feat/secure guest #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guest.js limits functionality so a user don't have access to director mode, host and filesharing.
The guest.html is a copy of main.html with the added import of guest.js just after lib.js
Setting up a ninja server with to urls. 1 pointing to index.html (with full functionality, and security for accessing) and one pointing to guest.html (with full access for others), ensures that an external user receiving a "solo view link", (replaces with the guest URL) can't mess around in director mode.
I'm not in love with the concept of copying the full main.html to guest.html, so if anyone can recommend a better way of reusing main.html into guest.html
😊