Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update Endpoints and Fix other endpoints for new schema #189

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

JonMike8
Copy link
Contributor

@JonMike8 JonMike8 commented Apr 5, 2024

#175, #140, #36 (i think)

Also updated the zod typechecking and DELETE endpoint to work with new schema
@JonMike8 JonMike8 added the backend Backend Task label Apr 5, 2024
app/api/v1/antenna/validate.ts Show resolved Hide resolved
app/api/v1/antenna/validate.ts Show resolved Hide resolved
@JonMike8 JonMike8 requested a review from OwenTruong April 12, 2024 16:50
OwenTruong
OwenTruong previously approved these changes Apr 12, 2024
miguel-merlin
miguel-merlin previously approved these changes Apr 19, 2024
Copy link
Member

@miguel-merlin miguel-merlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

app/api/v1/antenna/[id]/route.ts Show resolved Hide resolved
app/api/v1/antenna/[id]/route.ts Show resolved Hide resolved
app/api/v1/antenna/[id]/route.ts Show resolved Hide resolved
app/api/v1/antenna/[id]/route.ts Show resolved Hide resolved
@@ -14,3 +17,53 @@ export async function GET() {
return NextResponse.json({ message }, { status: 500 });
}
}

// request body should be:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary comments

app/api/v1/antenna/route.ts Show resolved Hide resolved
@miguel-merlin
Copy link
Member

@JonMike8 Do you want to do the merge? Or do you want me to do it?

@JonMike8
Copy link
Contributor Author

@miguel-merlin i can do it, doesn't look like many conflicts

@JonMike8 JonMike8 requested a review from miguel-merlin April 19, 2024 20:01
@miguel-merlin miguel-merlin merged commit 69e00a3 into main Apr 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants