Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/our sponsors - made layout to match figma design #165

Closed
wants to merge 2 commits into from
Closed

Feature/our sponsors - made layout to match figma design #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57ef532
made desktop layout match figma design
ZhaoYuLL Aug 9, 2024
7773363
made text for sponsors section more readable on mobile screens
ZhaoYuLL Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/_includes/_layouts/Home.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,19 +121,26 @@ export default ({ comp, title }) => {
redirect_url={"projects"}
/>
</section>
<section className="h-[17rem] bg-primary text-negative flex flex-col justify-evenly items-center justify-center py-16 max-lg:h-fit max-lg:gap-y-16 max-lg:py-16">
<h1 className="lg:text-5xl text-6xl mb-12">
<strong>Sponsors and Partners</strong>
<section
className="bg-negative text-negative flex flex-col justify-evenly py-16 max-lg:h-fit max-lg:gap-y-6 max-lg:py-16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add some horizontal padding to this section (to have it align with the padding of the right section of the hero page so using px-20). It just helps with making the page look more professional and presentable to these NPOs as this home page could be their first time interacting with our group yknow.

id="sponsors"
>
<h1 className="lg:text-5xl text-6xl mt-10 mb-2 ml-5 text-black text-left">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment to the comments made in the #163. Text should be larger on mobile view. If you addressed the above comment, keep in mind that the added padding will need to be adjusted to be smaller in mobile view too.

<strong>Our Sponsors</strong>
</h1>
<div className="flex flex-wrap gap-x-6 justify-center px-8 max-lg:px-4 max-md:px-2">
<p className="text-black text-left text-3xl lg:text-[1.7rem] ml-5 mb-10 max-lg:mb-8">
We are grateful to our sponsors who provide us with the resources
and support we need at Blueprint!
</p>
<div className="flex flex-wrap gap-x-6 justify-center px-8 max-lg:px-4 max-md:px-2 mb-10 max-lg:-mt-4">
<img
className="object-contain h-20 max-w-none mr-4"
src="../assets/logos/github.png"
src="../assets/logos/notion.png"
alt="GitHub logo"
/>
<img
className="object-contain h-20 max-w-none mr-4"
src="../assets/logos/notion.png"
src="../assets/logos/github.png"
alt="Notion logo"
/>
</div>
Expand Down