Skip to content

Commit

Permalink
Feat/deno version upgrade (#241)
Browse files Browse the repository at this point in the history
* tested with deno version 2.1.4

* ran prettier

* updated deno build version in github actions

* ran deno install

* updated denoland setup to v2

* auto install node modules

* ran prettier

* replaced class with className

* updated README
  • Loading branch information
Caposto authored Jan 2, 2025
1 parent 0c41709 commit 31d409a
Show file tree
Hide file tree
Showing 6 changed files with 1,067 additions and 1,145 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
uses: actions/checkout@v4

- name: Setup Deno environment
uses: denoland/setup-deno@v1
uses: denoland/setup-deno@v2
with:
deno-version: v1.x
deno-version: v2.x

- name: Build site
run: deno task build
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Thank you for wishing to contribute to our Chapter's Website! As stated [above](

## Setup for contributors

1. Ensure that you have Deno installed. You can skip this step if you do. If you don't or are unsure, you can use the following command to install it.
1. Ensure that you have Deno installed. We are using Deno 2 (version 2.1.4). You can skip this step if you do. If you don't or are unsure, you can use the following command to install it.

**Homebrew users:**

Expand All @@ -62,7 +62,7 @@ Thank you for wishing to contribute to our Chapter's Website! As stated [above](

Re-run the curl command.

Restart your terminal or enter a new one. To confirm deno was installed, check the version by running `deno --version`, should see something like `deno 1.37.2`
Restart your terminal or enter a new one. To confirm deno was installed, check the version by running `deno --version`, should see something like `deno 2.1.4`

You can find more information on the [Deno Docs](https://docs.deno.com/runtime/manual/getting_started/installation)

Expand All @@ -86,7 +86,7 @@ Thank you for wishing to contribute to our Chapter's Website! As stated [above](

`npm run format:write`

Note: make sure npm is installed on your machine
Note: make sure npm is installed on your machine. The reason we are using npm for prettier as opposed to `deno fmt` is because of the `prettier-plugin-tailwindcss` npm pacakge. This helps us format our tailwindcss classes correctly, and currently, there is no deno equivalent.

## For Project Teams Updating their Project Page

Expand Down
4 changes: 2 additions & 2 deletions deno.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"tasks": {
"lume": "echo \"import 'lume/cli.ts'\" | deno run --unstable -A -",
"lume": "echo \"import 'lume/cli.ts'\" | deno run -A -",
"build": "deno task lume",
"serve": "deno task lume -s"
},
Expand All @@ -12,8 +12,8 @@
"exclude": ["no-unused-vars"]
}
},
"nodeModulesDir": "auto",
"compilerOptions": {
"allowJs": true,
"lib": ["deno.window"],
"strict": true,
"jsx": "react-jsx",
Expand Down
Loading

0 comments on commit 31d409a

Please sign in to comment.