feat: added sidebar (#1) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-merlin
requested changes
Feb 22, 2024
src/components/Sidebar.tsx
Outdated
| <Flex width="100%" height="100%" backgroundColor="blue.500" direction="column" justifyContent="space-between" color="white"> | ||
| <Box> | ||
| <HStack padding="16px"> | ||
| <Image src='' alt="Blueprint Logo" boxSize="100px"></Image> |
There was a problem hiding this comment.
@ZhangTerrence I just added the logos in your branch feat/sidebar under src/assets/images. Can you update the src
|
I updated the image srcs, added routing functionality to the buttons, and moved Sidebar to HomePage. As for the icons, I was able to get some free svgs so I created custom icons which I temporarily put in the icons directory. |
|
You're crazy. Thanks |
ZhangTerrence
force-pushed
the
feat/sidebar
branch
from
cb58cef to
c95ad3c
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the sidebar but there are some features I wasn't able to add:
Also I put the Sidebar components in a newly created components directory. I wasn't sure where to put it for this project it's there for now.