Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created the AddUser button on the Dashboard page #23

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

Lucasha11
Copy link
Contributor

Created the "Add User" button on the dashboard page. When request is successful, alert is displayed on screen. "Add User" has two inputs "Email" and "Roles."

@Lucasha11 Lucasha11 requested a review from miguel-merlin April 2, 2024 15:47
Copy link
Member

@miguel-merlin miguel-merlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please address the comments I've made. Keep it up!

README.md Outdated Show resolved Hide resolved
src/components/CreateUserButton.tsx Show resolved Hide resolved
src/components/CreateUserButton.tsx Outdated Show resolved Hide resolved
src/components/CreateUserButton.tsx Outdated Show resolved Hide resolved
src/components/CreateUserButton.tsx Outdated Show resolved Hide resolved
src/components/CreateUserButton.tsx Outdated Show resolved Hide resolved
src/components/CreateUserButton.tsx Show resolved Hide resolved
src/pages/DashboardPage.tsx Outdated Show resolved Hide resolved
src/pages/DashboardPage.tsx Outdated Show resolved Hide resolved
src/pages/DashboardPage.tsx Outdated Show resolved Hide resolved
@Lucasha11 Lucasha11 requested a review from miguel-merlin April 4, 2024 20:09
@miguel-merlin
Copy link
Member

@Lucasha11 This one was a tricky one! You cannot have async functions onSubmit. To handle API calls onSubmit, you need to write your submit handler in such a way that the promise is handled internally. Please keep working on the comments I provided; let me know if you have any questions. Please, when requesting the review, resolve all the comments you have addressed.

@Lucasha11
Copy link
Contributor Author

Miguel resolved my async issue. This PR should contain the completed "Add User Button."

Copy link
Member

@miguel-merlin miguel-merlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@miguel-merlin miguel-merlin merged commit 5c3f9f6 into main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants