-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update error #17
Fix update error #17
Conversation
Any chance we can get this merged? |
@stevenmaguire can you merge it? |
@colq2 Thanks for your patience on this. I have been reluctant to simply merge this as is because of the lack of test cases that demonstrate the specific use case that is being addressed here. Would you mind adding some specific tests to cover this use case? |
Yes, I will add some tests soon. |
Thank you! |
@colq2 do you need help on this? What is the current status? |
Hello @lobodol and @stevenmaguire, "Invalid response received from Authorization Server. Expected JSON." is an exception which occurs because, as I said, keycloak responses with just a string. I think there is no reason why you would not merge this. |
I'm happy to add another contributor to this project - #27 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mstefan21 Any chance to get it merged after all this time? Downstream projects might not be able to update past 2.0.0 because of conflicting dependency constraints.
@arthurtemple Sorry for late reply, I will look at the end of this week and prepare relase of new version |
@arthurtemple Released as version 2.2.2 |
Very nice, thanks! |
This pull request solves #15 .
The problem was
parseResponse
function from AbstractProvider which force the reponse to be an array and have no possibility to parseapplication/jwt
.If we use encrypted userinfo endpoint we are getting only the jwt token which is a simple string.
This results in an
UnexpectedValueException
with the message An OAuth server error was encountered that did not contain a JSON body. Also seeAbstractProvider
line 694.