Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options: nlopt_set_xtol_abs check xtol_abs #462

Merged
merged 1 commit into from
Jan 11, 2023
Merged

options: nlopt_set_xtol_abs check xtol_abs #462

merged 1 commit into from
Jan 11, 2023

Conversation

jschueller
Copy link
Collaborator

Closes #461

@jschueller jschueller mentioned this pull request Jul 4, 2022
Closed
@jschueller jschueller marked this pull request as ready for review July 5, 2022 06:50
@jschueller
Copy link
Collaborator Author

ping @stevengj

stevengj
stevengj reviewed Jan 11, 2023
View reviewed changes
src/api/options.c Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Jan 11, 2023
View reviewed changes
src/api/options.c Outdated Show resolved Hide resolved
@stevengj
Copy link
Owner

LGTM. The docs should also be updated to note that passing NULL is (now) allowed here to to unset the tol/weights.

@jschueller jschueller merged commit 4758b41 into stevengj:master Jan 11, 2023
@jschueller jschueller deleted the set_xtol branch January 11, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

null pointer dereference in nlopt_optimize_ / nlopt_set_xtol_abs
2 participants
@jschueller @stevengj